feat: add support for testID #179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0228809 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
okwasniewski
reviewed
Dec 4, 2024
Member
okwasniewski
left a comment
okwasniewski
left a comment
There was a problem hiding this comment.
Thanks for working on this!
packages/react-native-bottom-tabs/android/src/main/java/com/rcttabview/RCTTabView.kt
Outdated
Show resolved
Hide resolved
packages/react-native-bottom-tabs/android/src/main/java/com/rcttabview/RCTTabView.kt
Outdated
Show resolved
Hide resolved
Nodonisko
force-pushed
the
feat/add-test-id-support
branch
from
39c8ecf to
2fa9c5c
Compare
okwasniewski
reviewed
Dec 5, 2024
Member
There was a problem hiding this comment.
We are getting closer!
Looks like you are missing new architecture implementation:
- Pass testID here:
https://github.com/okwasniewski/react-native-bottom-tabs/blob/d43f39de757403492c105a417272c15a674dd429/packages/react-native-bottom-tabs/ios/Fabric/RCTTabViewComponentView.mm#L199C5-L204C62 - Pass testID to the compare function:
https://github.com/okwasniewski/react-native-bottom-tabs/blob/d43f39de757403492c105a417272c15a674dd429/packages/react-native-bottom-tabs/ios/Fabric/RCTTabViewComponentView.mm#L176
Nodonisko
force-pushed
the
feat/add-test-id-support
branch
from
b69ab92 to
dcf07a1
Compare
Contributor
Author
|
Fixed and tested on new arch iOS and it works correctly |
Nodonisko
force-pushed
the
feat/add-test-id-support
branch
from
dcf07a1 to
13ffdd5
Compare
okwasniewski
approved these changes
Dec 7, 2024
Member
okwasniewski
left a comment
okwasniewski
left a comment
There was a problem hiding this comment.
Thanks for working on this!
|
Hello, this does not seem to be working. I'm not seeing any
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR adds support for
testIDwhich normal RNViewhas. So now it's possible to use E2E frameworks like Detox to click on tab item bytestID.How to test?
Screenshots